From 8c5d054f86e949d27a4c900c38dac3dcbeace062 Mon Sep 17 00:00:00 2001 From: neru Date: Thu, 18 Jun 2026 18:22:52 -0300 Subject: [PATCH] style: remove repeated code, group in tasks --- src/dumper/main.cs | 41 ++++++++++++++++++----------------------- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/src/dumper/main.cs b/src/dumper/main.cs index 95be629..869883b 100644 --- a/src/dumper/main.cs +++ b/src/dumper/main.cs @@ -10,33 +10,28 @@ if (!hasInitialized) return 1; } -log.Info("Getting character data and icons"); -try +var dumpTasks = new (string Name, Action Execute)[] { - dumper.DumpCharacters(); - dumper.DumpCharacterIcons(); -} -catch (Exception er) -{ - log.Error("Error while dumping characters"); - log.Error("Exception: {0}", er.ToString()); - Console.ReadKey(); - return 1; -} + ("character", () => { dumper.DumpCharacters(); dumper.DumpCharacterIcons(); }), + ("item", () => { dumper.DumpItems(); dumper.DumpItemIcons(); }), + ("offering", () => { dumper.DumpOfferings(); dumper.DumpOfferingIcons(); }) +}; -log.Info("Getting item data and icons"); -try +foreach (var task in dumpTasks) { - dumper.DumpItems(); - dumper.DumpItemIcons(); -} -catch (Exception er) -{ - log.Error("Error while dumping items"); - log.Error("Exception: {0}", er.ToString()); - Console.ReadKey(); - return 1; + log.Info($"Getting {task.Name} data and icons"); + try + { + task.Execute(); + } + catch (Exception er) + { + log.Error($"Error while dumping {task.Name}s"); + log.Error("Exception: {0}", er.ToString()); + Console.ReadKey(); + return 1; + } } log.Info("Dump finished");